Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 5.2.4 Operation Type Exists #1098

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add 5.2.4 Operation Type Exists #1098

wants to merge 5 commits into from

Conversation

Shane32
Copy link

@Shane32 Shane32 commented May 27, 2024

Closes #1097

@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited
Loading

✅ Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 6f187fa
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/665f1e6cadd495000824e5fd
😎 Deploy Preview https://deploy-preview-1098--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shane32 Shane32 mentioned this pull request May 28, 2024
Merged
24 tasks
@benjie benjie added the 💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md) label Jun 4, 2024
benjie
benjie previously requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

spec/Section 5 -- Validation.md Outdated Show resolved Hide resolved
spec/Section 5 -- Validation.md Outdated Show resolved Hide resolved
spec/Section 5 -- Validation.md Outdated Show resolved Hide resolved
spec/Section 5 -- Validation.md Outdated Show resolved Hide resolved
spec/Section 5 -- Validation.md Outdated Show resolved Hide resolved
@Shane32 Shane32 changed the title Add 5.2.4 Operation Type Configuration Add 5.2.4 Operation Type Exists Jun 4, 2024
@dondonz dondonz mentioned this pull request Jun 4, 2024
Open
@benjie benjie dismissed their stale review June 5, 2024 10:16

All points were addressed

benjie
benjie approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though some slight editorial on the wording to match the style of the spec as a whole might be warranted.

JoviDeCroock
JoviDeCroock approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great validation rule 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No validation rule exists to assert mutation/subscription operations exist in the schema
3 participants
@Shane32 @benjie @JoviDeCroock