Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish: fix lexer state comment #4294

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

yaacovCR
Copy link
Contributor

we must update the lexer line number and the line start position, because lookahead saves the token within the linked list, and so will never be called again on this token

we do not change the current token, however, until the lexer is advanced

closes #2764

we must update the lexer line number and the line start position, because lookahead saves the token within the linked list, and so will never be called again on this token

we do not change the current token, however, until the lexer is advanced
@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Nov 11, 2024
@yaacovCR yaacovCR requested a review from a team as a code owner November 11, 2024 11:19
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit caa36da
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6731e85cf7a2e9000754d80c
😎 Deploy Preview https://deploy-preview-4294--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the title fix lookahead comment fix lexer comment Nov 11, 2024
@yaacovCR yaacovCR changed the title fix lexer comment polish: fix lexer state comment Nov 11, 2024
@yaacovCR yaacovCR merged commit 92d4ed0 into graphql:main Nov 11, 2024
22 checks passed
@yaacovCR yaacovCR deleted the fix-lexer-comment branch November 11, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants