Provide people with tabs so they can use classes as well #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
bc93642
to
a3e172a
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
a3e172a
to
ff51604
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
2 times, most recently
from
076abdb
to
53dae86
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
53dae86
to
a0cd603
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
a0cd603
to
b036677
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
b036677
to
b6a6028
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
b6a6028
to
401dcac
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
401dcac
to
7a5f066
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
7a5f066
to
9b84ceb
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
9b84ceb
to
4af2c5d
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
39ac537
to
4386ab0
Compare
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
4386ab0
to
7aef054
Compare
yaacovCR
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
I haven’t found the time yet to get through every line, but I love the idea of tabs!
One question I have is whether we want to call these SDL-first vs code-first …. Our SDL-first currently requires using the root value/parent method of providing resolvers but the eventual plan would be to allow resolvers as additional arguments to buildschema just like graphql tools makeExecutableSchema…
JoviDeCroock
force-pushed
the
classes-alternative
branch
from
7aef054
to
7a298ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides people with the option to choose between the template approach or the classes approach. This is a proposal to tackle #1368
Preview
This has been applied throughout the codebase now, however one of the things I am uncertain about is how we offer
buildSchemawith the GraphQLDefer/... directives? Should we add an option tobuildSchema? The exports defined in that chapter seem to only exist in v17 so we should explicitly flag that.