-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add experimental support for parsing fragment arguments #4015
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: mjmahone <[email protected]>
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for rebasing the syntax changes! This looks correct to me.
I'm not sure whether we need the full stack of changes up before merging any of the changes: I'd be surprised if the syntax changes need to be modified due to the validation or execution changes.
This update is probably worth bringing to the graphql-wg this week: https://github.com/graphql/graphql-wg/blob/main/agendas/2024/02-Feb/01-wg-primary.md
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
@mjmahone worth bringing up that the PR is up, or should that be for the graphql-js wg? Not entirely sure 😅 |
CC @graphql/graphql-js-reviewers |
The implementation in this branch passes tests but uses Basically, the spec proposal uses The spec then uses versions of |
I think it's worth adding a 5-10 minute dicussion item to the WG meeting this thursday https://github.com/graphql/graphql-wg/blob/main/agendas/2024/02-Feb/01-wg-primary.md |
I don't think that is true anymore? I think @JoviDeCroock removed all the UNSET hacks from this PR (they might still exist in the executor changes). It also looks like graphql-js #4015 no longer uses the UNSET hack. We should definitely ship the graphql-js changes that most closely match the changes to the spec itself, and the UNSET hack does not match the spec changes from Spec #1081 , but this looks like the parser changes are in a reasonably good state right now to my eyes! |
@mjmahone yeah it doesn't use it it's just the parser. The execution PR also uses the new spec text |
@graphql/graphql-js-reviewers is there anything missing to move this and the linked PR's forward? |
So excited for this! Let me know if you want any help testing it in a real app. |
This is a rebase of #3847
This implements execution of Fragment Arguments, and more specifically visiting, parsing and printing of fragment-spreads with arguments and fragment definitions with variables, as described by the spec changes in graphql/graphql-spec#1010. There are a few amendments in terms of execution and keying the fragment-spreads, these are reflected in mjmahone/graphql-spec#3
The purpose is to be able to independently review all the moving parts, the stacked PR's will contain mentions of open feedback that was present at the time.
CC @mjmahone the original author