Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cancels deferred fields when overlapping deferred results exhibits null bubbling #3983

Closed
wants to merge 1 commit into from

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Nov 7, 2023

Given the following operation:

      query {
        ... @defer {
          hero {
            nonNullName
            id
          }
        }
        ... @defer {
          hero {
            nonNullName
            name
          }
        }
      }

If nonNullName returns null, the separate incremental entry with that overlapping field will error, and all the "sibling" incremental errors should also be filtered.

@yaacovCR yaacovCR added the PR: bug fix 🐞 requires increase of "patch" version number label Nov 7, 2023
Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit b6b15c6
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/654a0df2c5baad0008aed079
😎 Deploy Preview https://deploy-preview-3983--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 7, 2023

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR
Copy link
Contributor Author

this additional filtering test case is fixed by the rewrite in #4026 with the test case included => it could be fixed separately prior to #4026, but I do not see the need.

@yaacovCR yaacovCR closed this Mar 20, 2024
@yaacovCR yaacovCR deleted the more-null-bubbling-filtering branch September 5, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant