Validate variables are known types #3282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this rule the correct place to add this validation? Should we modify the spec to make this validation rule explicit? |
spawnia
force-pushed
the
validate-unknown-variable-types
branch
from
ba68812
to
876dd47
Compare
spawnia
force-pushed
the
validate-unknown-variable-types
branch
from
876dd47
to
e21ef92
Compare
Adds a check to the validation rule VariablesAreInputTypes to ensure that referenced types exist at all before checking they are input types. This check is not explicitly described in the specification for validating variables: http://spec.graphql.org/draft/#sec-Validation.Variables I am assuming this is simply an oversight and the rule is implicit. Still, it is valuable to check for it in order to provide a proper error to clients.
spawnia
force-pushed
the
validate-unknown-variable-types
branch
from
e21ef92
to
2eeafec
Compare
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Oct 1, 2021
|
@spawnia Thanks for opening PR 👍 Since code changes are not relevant anymore I'm closing this PR.
I did a quick cross-check and we have a bunch of discrepancies with the spec, so I opened a separate issue for that: #3286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to the validation rule VariablesAreInputTypes to ensure
that referenced types exist at all before checking they are input types.
This check is not explicitly described in the specification for validating
variables: http://spec.graphql.org/draft/#sec-Validation.Variables
I am assuming this is simply an oversight and the rule is implicit.
Still, it is valuable to check for it in order to provide a proper error to clients.