-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate @graphiql/react
to vitest
#3829
Conversation
|
export default function MockedIcon(props) { | ||
return ( | ||
<svg {...props}> | ||
<title>mocked icon</title> | ||
</svg> | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as an improvement we no longer provide mocks for tests, but process them with the same svg loader used for build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
===========================================
+ Coverage 58.49% 82.09% +23.59%
===========================================
Files 109 49 -60
Lines 6115 3680 -2435
Branches 1924 1150 -774
===========================================
- Hits 3577 3021 -556
+ Misses 2522 652 -1870
+ Partials 16 7 -9 |
The latest changes of this PR are not available as canary, since there are no linked |
brings to improvements