Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate @graphiql/react to vitest #3829

Merged
merged 6 commits into from
Dec 14, 2024
Merged

migrate @graphiql/react to vitest #3829

merged 6 commits into from
Dec 14, 2024

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Dec 14, 2024

brings to improvements

  • use the same svg loader used for build
  • use react-compiler for components

Copy link

changeset-bot bot commented Dec 14, 2024

⚠️ No Changeset found

Latest commit: 658613d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines -1 to -7
export default function MockedIcon(props) {
return (
<svg {...props}>
<title>mocked icon</title>
</svg>
);
}
Copy link
Collaborator Author

@dimaMachina dimaMachina Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as an improvement we no longer provide mocks for tests, but process them with the same svg loader used for build

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.09%. Comparing base (efde1a0) to head (658613d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3829       +/-   ##
===========================================
+ Coverage   58.49%   82.09%   +23.59%     
===========================================
  Files         109       49       -60     
  Lines        6115     3680     -2435     
  Branches     1924     1150      -774     
===========================================
- Hits         3577     3021      -556     
+ Misses       2522      652     -1870     
+ Partials       16        7        -9     

see 60 files with indirect coverage changes

Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@dimaMachina dimaMachina merged commit d3584b2 into main Dec 14, 2024
14 checks passed
@dimaMachina dimaMachina deleted the graphiql-react-vitest branch December 14, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant