Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add defaultTheme prop to specify default theme if no previous value stored #3619

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yahkob
Copy link
Contributor

@Yahkob Yahkob commented May 29, 2024

I'm not sure if this is too big of a change but would love to have a way to provide an optional prop to show GraphiQL in a specific theme.

Copy link

changeset-bot bot commented May 29, 2024

⚠️ No Changeset found

Latest commit: 4299163

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

linux-foundation-easycla bot commented May 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Yahkob / name: Jake Harclerode (4299163)

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.78%. Comparing base (fa0e7f7) to head (4299163).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3619      +/-   ##
==========================================
- Coverage   60.80%   60.78%   -0.03%     
==========================================
  Files         120      120              
  Lines        5616     5618       +2     
  Branches     1487     1488       +1     
==========================================
  Hits         3415     3415              
- Misses       1749     1750       +1     
- Partials      452      453       +1     
Files Coverage Δ
packages/graphiql/src/components/GraphiQL.tsx 68.70% <100.00%> (ø)
packages/graphiql-react/src/theme.ts 37.50% <0.00%> (-3.41%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant