Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make props optional to avoid passing empty object #3618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make props optional to avoid passing empty object #3618

wants to merge 1 commit into from

Conversation

Yahkob
Copy link
Contributor

@Yahkob Yahkob commented May 29, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7851db4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Yahkob
Yahkob commented May 30, 2024
View reviewed changes
packages/graphiql-plugin-explorer/src/graphiql-explorer.d.ts
@@ -52,7 +52,7 @@ declare module 'graphiql-explorer' {
buttonStyle?: CSSProperties;
actionButtonStyle?: CSSProperties;
} | null;
showAttribution: boolean;
showAttribution?: boolean;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a global search for this prop but couldn't really find anything so sadly I will admit I just made it optional without fully understanding the implications 😓

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's fine, as these are manually maintained types for the external graphql-explorer flow library, I can show a PR where i convert it to ts and adopt it into the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acao acao acao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yahkob @acao