Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improve scrollbar styling on the query editor #3605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TPXP
Copy link

@TPXP TPXP commented May 20, 2024

This changes makes scrollbars in the graphiql editor transparent, so that they look better integrated in the interface

Before After
Capture d’écran 2024-05-20 à 12 47 42 Capture d’écran 2024-05-20 à 12 47 37

Scrollbars are transparent, so they look nice in light mode as well
Capture d’écran 2024-05-20 à 12 50 02

I tested this on MacOS in Chrome, Firefox and Safari

Inspired by codemirror/codemirror5#6882 as well

Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: 0926501

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@graphiql/react Patch
graphiql Patch
@graphiql/plugin-code-exporter Patch
@graphiql/plugin-explorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

linux-foundation-easycla bot commented May 20, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: TPXP / name: Thomas P. (0926501)

@TPXP TPXP force-pushed the style-transparent-scrollbars branch 2 times, most recently from 2c873de to 4f97923 Compare May 20, 2024 11:15
This changes makes scrollbars in the graphiql editor transparent, so that they look better integrated in the interface
@TPXP TPXP force-pushed the style-transparent-scrollbars branch from 4f97923 to 0926501 Compare May 20, 2024 14:01
@acao
Copy link
Member

acao commented May 28, 2024

@TPXP beautiful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants