Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphiQL component: disableTabs prop #3408

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

TuvalSimha
Copy link
Contributor

@TuvalSimha TuvalSimha commented Aug 22, 2023

Closes issue: #3373

Description:

  • Now we can control the use of tabs and allow disabling tabs.

Result UI:

  • No tabs at all:
Screenshot 2023-08-22 at 16 27 41

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

🦋 Changeset detected

Latest commit: 4348fd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TuvalSimha TuvalSimha changed the title GraphiQL: disableTabs prop GraphiQL component: disableTabs prop Aug 22, 2023
@dotansimha dotansimha requested a review from dimaMachina August 23, 2023 08:30
@acao
Copy link
Member

acao commented Oct 31, 2023

@TuvalSimha awesome, thank you!

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #3408 (4348fd7) into main (2348641) will increase coverage by 0.06%.
Report is 38 commits behind head on main.
The diff coverage is 73.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3408      +/-   ##
==========================================
+ Coverage   55.75%   55.81%   +0.06%     
==========================================
  Files         110      110              
  Lines        5243     5273      +30     
  Branches     1426     1439      +13     
==========================================
+ Hits         2923     2943      +20     
- Misses       1897     1901       +4     
- Partials      423      429       +6     
Files Coverage Δ
packages/graphiql-react/src/editor/context.tsx 73.39% <100.00%> (ø)
...raphql-language-service-server/src/GraphQLCache.ts 50.88% <50.00%> (ø)
...nguage-service/src/utils/getVariablesJSONSchema.ts 94.59% <98.38%> (+0.71%) ⬆️
packages/graphiql/src/components/GraphiQL.tsx 68.70% <40.00%> (-1.23%) ⬇️
...ql-language-service-server/src/MessageProcessor.ts 45.83% <55.00%> (-0.40%) ⬇️
packages/graphiql-react/src/editor/hooks.ts 40.15% <23.52%> (+1.56%) ⬆️

@acao acao merged commit a808019 into graphql:main Dec 11, 2023
14 checks passed
@acao acao mentioned this pull request Dec 11, 2023
@acao
Copy link
Member

acao commented Jan 11, 2024

I think there was a bug introduced with this PR so we will have to revert it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants