Skip to content

Commit

Permalink
configure more gh actions for node LTS (#3613)
Browse files Browse the repository at this point in the history
* finish upgrading to node 18

* fix: node version
  • Loading branch information
acao committed May 28, 2024
1 parent aa6dbbb commit 85fd989
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 10 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/main-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ jobs:
uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
cache: yarn
- name: Cache node modules
id: cache-modules
Expand All @@ -36,8 +35,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16

- id: cache-modules
uses: actions/cache@v3
with:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/pr-graphql-compat-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
- uses: actions/setup-node@v3
with:
cache: yarn
node-version: 16
- name: Cache node modules
uses: actions/cache@v3
with:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
cache: yarn
- name: Cache node modules
uses: actions/cache@v3
Expand Down
9 changes: 4 additions & 5 deletions packages/graphql-language-service-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,10 @@ Supported features include:

### Dependencies

An LSP compatible client with its own file watcher, that sends watch
notifications to the server.

**DROPPED**: GraphQL Language Service no longer depends on
[Watchman](https://facebook.github.io/watchman/)
- An LSP compatible client with its own file watcher, that sends watch
notifications to the server, such as vscode, nvim, or sublime-lsp.
- Node.js `^18.18.0 || >=20.9.0` or later is required.
- (for now) a graphql config file is required

### Installation

Expand Down

0 comments on commit 85fd989

Please sign in to comment.