Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sec): set default maximum batching size to 500 to prevent Denial-of-Service #364

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(sec): set default maximum batching size to 500 to prevent Denial-of-Service #364

wants to merge 2 commits into from
+8 −3

Conversation

hainenber
Copy link

@hainenber hainenber commented Oct 29, 2024 •
edited
Loading

A light attempt to resolve SNYK-JS-DATALOADER-8248488 by setting up a default maxBatchSize to be 500.

The limit is chosen arbitrarily along with inspiration from Elastic's Beats equivalent

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 29, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@hainenber hainenber changed the title fix(sec): set default maximum batching size to 1000 to prevent Denial-of-Service fix(sec): set default maximum batching size to 500 to prevent Denial-of-Service Oct 30, 2024
saihaj
saihaj requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider this as a breaking change. We are changing a default limit and potentially for someone it can start breaking the CI if they don't adjust this limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hainenber @saihaj