Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Subgraph" to "Source schema" in Schema Composition document #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change "Subgraph" to "Source schema" in Schema Composition document #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions spec/Section 4 -- Composition.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,12 +340,12 @@ as `@external` in another. The argument `language` has the same default value in
both source schemas, satisfying the rule:

```graphql example
# Subgraph A
# Source schema A
type Product {
name(language: String = "en"): String
}

# Subgraph B
# Source schema B
type Product {
name(language: String = "en") @external: String
}
Expand All @@ -356,12 +356,12 @@ as `@external` in another. The argument `language` has different default values
in the two source schemas, violating the rule:

```graphql counter-example
# Subgraph A
# Source schema A
type Product {
name(language: String = "en"): String
}

# Subgraph B
# Source schema B
type Product {
name(language: String = "de") @external: String
}
Expand All @@ -374,12 +374,12 @@ not have a default value in the source schema where the field is marked as
`@external`, violating the rule:

```graphql counter-example
# Subgraph A
# Source schema A
type Product {
name(language: String = "en"): String
}

# Subgraph B
# Source schema B
type Product {
name(language: String): String @external
}
Expand Down Expand Up @@ -430,12 +430,12 @@ field in source schema B and the base field in source schema A, satisfying the
rule:

```graphql example
# Subgraph A
# Source schema A
type Product {
name(language: String): String
}

# Subgraph B
# Source schema B
type Product {
name(language: String): String @external
}
Expand All @@ -446,12 +446,12 @@ argument that is present in the base field definition in source schema A,
violating the rule:

```graphql counter-example
# Subgraph A
# Source schema A
type Product {
name(language: String): String
}

# Subgraph B
# Source schema B
type Product {
name: String @external
}
Expand Down Expand Up @@ -502,12 +502,12 @@ Here, the `@external` field's `language` argument has the same type (`Language`)
as the base field, satisfying the rule:

```graphql example
# Subgraph A
# Source schema A
type Product {
name(language: Language): String
}

# Subgraph B
# Source schema B
type Product {
name(language: Language): String
}
Expand All @@ -518,12 +518,12 @@ the base field's `language` argument type (`Language` vs. `String`), violating
the rule:

```graphql example
# Subgraph A
# Source schema A
type Product {
name(language: Language): String
}

# Subgraph B
# Source schema B
type Product {
name(language: String): String
}
Expand Down Expand Up @@ -569,13 +569,13 @@ Here, the `name` field on `Product` is defined in source schema A and marked as
definition in source schema A:

```graphql example
# Subgraph A
# Source schema A
type Product {
id: ID
name: String
}

# Subgraph B
# Source schema B
type Product {
id: ID
name: String @external
Expand All @@ -587,12 +587,12 @@ source schema B but has no non-`@external` declaration in any other source
schema, violating the rule:

```graphql counter-example
# Subgraph A
# Source schema A
type Product {
id: ID
}

# Subgraph B
# Source schema B
type Product {
id: ID
name: String @external
Expand Down Expand Up @@ -638,12 +638,12 @@ Here, the `@external` field `name` has the same return type (`String`) as the
base field definition, satisfying the rule:

```graphql example
# Subgraph A
# Source schema A
type Product {
name: String
}

# Subgraph B
# Source schema B
type Product {
name: String @external
}
Expand All @@ -653,12 +653,12 @@ In this example, the `@external` field `name` has a return type of `ProductName`
that doesn't match the base field's return type `String`, violating the rule:

```graphql counter-example
# Subgraph A
# Source schema A
type Product {
name: String
}

# Subgraph B
# Source schema B
type Product {
name: ProductName @external
}
Expand Down Expand Up @@ -699,7 +699,7 @@ In this example, the `name` field is marked with `@external` and is used by the
`@provides` directive, satisfying the rule:

```graphql example
# Subgraph A
# Source schema A
type Product {
id: ID
name: String @external
Expand All @@ -714,7 +714,7 @@ In this example, the `name` field is marked with `@external` but is not used by
the `@provides` directive, violating the rule:

```graphql counter-example
# Subgraph A
# Source schema A
type Product {
title: String @external
author: Author
Expand Down
Loading