Adds validation rule @lookup should have nullable return type
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glen-84
suggested changes
Oct 3, 2024
| To properly handle cases where the requested entity does not exist, such fields should have a nullable return type. | ||
| This allows the field to return `null` when an entity matching the provided criteria is not found, following the standard GraphQL practices for representing missing data. | ||
|
|
||
| In a distributed system, it is likely that some entities are not be found on other subgraphs, even when those subgraphs contribute fields to the type. |
There was a problem hiding this comment.
Suggested change
| In a distributed system, it is likely that some entities are not be found on other subgraphs, even when those subgraphs contribute fields to the type. | |
| In a distributed system, it is likely that some entities will not be found on other subgraphs, even when those subgraphs contribute fields to the type. |
|
|
||
| In this example, `userById` returns a nullable `User` type, aligning with the recommendation. | ||
|
|
||
| This counter-example demonstrates a invalid usage: |
There was a problem hiding this comment.
Suggested change
| This counter-example demonstrates a invalid usage: | |
| This counter-example demonstrates an invalid usage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.