Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Input Field Default Mismatch Rule #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelstaib
Copy link
Member

No description provided.

@michaelstaib michaelstaib changed the title Added Input Field Default Mismatch Rule Adds Input Field Default Mismatch Rule Aug 8, 2024

**Error Code**

`Input_Field_Default_Mismatch`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Input_Field_Default_Mismatch`
`INPUT_FIELD_DEFAULT_MISMATCH`

- For each {inputFields} in {inputFieldsByName}:
- Let {defaultValues} be a set containing the default values of each input
field in {inputFields}.
- If the size of {defaultValues} is greater than
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greater than what? 🙂


Input fields in different source schemas that have the same name are required to have
consistent default values. This ensures that there is no ambiguity or
inconsistency when merging schemas from different source schemas.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inconsistency when merging schemas from different source schemas.
inconsistency when merging input fields from different source schemas.

Comment on lines +56 to +72
input Filter {
field1: Enum1 = Value1
}

enum Enum1 {
Value1
Value2
}

input Filter {
field1: Enum1 = Value1
}

enum Enum1 {
Value1
Value2
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
input Filter {
field1: Enum1 = Value1
}
enum Enum1 {
Value1
Value2
}
input Filter {
field1: Enum1 = Value1
}
enum Enum1 {
Value1
Value2
}
input Filter {
field1: Enum1 = VALUE1
}
enum Enum1 {
VALUE1
VALUE2
}
input Filter {
field1: Enum1 = VALUE1
}
enum Enum1 {
VALUE1
VALUE2
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants