Adds Input With Missing Required Fields #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glen-84
suggested changes
Aug 4, 2024
Co-authored-by: Glen <[email protected]>
Co-authored-by: Glen <[email protected]>
Co-authored-by: Glen <[email protected]>
Co-authored-by: Glen <[email protected]>
Co-authored-by: Glen <[email protected]>
Co-authored-by: Glen <[email protected]>
Co-authored-by: Glen <[email protected]>
# warning
input Input1 {
field1: String
}
input Input1 {
field2: String
}
# error
input Input1 {
field1: String!
}
input Input1 {
field2: String
} |
PascalSenn
changed the title
glen-84
suggested changes
Nov 10, 2024
|
|
||
| - Let `{requiredFields}` be the intersection of all required field names across all input objects in `{inputs}`. | ||
| - For each `{input}` in `{inputs}`: | ||
| - Let `{inputFields}` be the set of all field names in of required fields in `{input}`. |
There was a problem hiding this comment.
Suggested change
| - Let `{inputFields}` be the set of all field names in of required fields in `{input}`. | |
| - Let `{inputFields}` be the set of all field names of required fields in `{input}`. |
| This rule only checks that the field names are the same, not that the field types are the same. | ||
| Field types are checked by the [Input Field Types mergeable](#sec-Input-Field-Types-mergeable) rule. | ||
| Input types are merged by intersection, meaning that the merged input type will have all fields that are present in all input types with the same name. | ||
| This rule ensures that input object types with the same name across different subgraphs share a consistent set of required fields. |
There was a problem hiding this comment.
Are we reverting to "subgraph" naming again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.