Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Core Source Schema Directives #30

Merged
merged 50 commits into from
Oct 24, 2024
Merged

Introduce Core Source Schema Directives #30

merged 50 commits into from
Oct 24, 2024

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Apr 11, 2024 •
edited
Loading

This PR introduces the core directives for source schema to the specification.

@michaelstaib michaelstaib mentioned this pull request Apr 11, 2024
Closed
@michaelstaib michaelstaib self-assigned this Apr 11, 2024
benjie
benjie reviewed May 23, 2024
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more missing colons I've missed.

spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
glen-84
glen-84 suggested changes Jun 15, 2024
View reviewed changes
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
glen-84
glen-84 suggested changes Jul 25, 2024
View reviewed changes
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
spec/Section 2 -- Source Schema.md Outdated Show resolved Hide resolved
@michaelstaib michaelstaib changed the title Introduce Lookup Directive. Source Schema Chapter Aug 1, 2024
@michaelstaib michaelstaib marked this pull request as ready for review October 3, 2024 13:30
@michaelstaib michaelstaib changed the title Source Schema Chapter Introduce Core Source Schema Directives Oct 24, 2024
@michaelstaib michaelstaib merged commit 3800161 into main Oct 24, 2024
5 checks passed
@michaelstaib michaelstaib deleted the mst/lookup branch October 24, 2024 14:09
PascalSenn pushed a commit to PascalSenn/composite-schemas-spec that referenced this pull request Nov 7, 2024
@michaelstaib @PascalSenn
Introduce Core Source Schema Directives (graphql#30)
8ae3f88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariuszkuc dariuszkuc dariuszkuc left review comments

@smyrick smyrick smyrick left review comments

@benjie benjie benjie left review comments

@glen-84 glen-84 glen-84 requested changes

@kamilkisiela kamilkisiela kamilkisiela approved these changes

Assignees

@michaelstaib michaelstaib

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michaelstaib @benjie @glen-84 @smyrick @kamilkisiela @dariuszkuc