Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Overview less prescriptive #23

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

SimonSapin
Copy link
Contributor

This "must" came across as opinionated on what the reader should do, rather than what composition can empower them to do.

This "must" came across as opinionated on what the reader should do,
rather than what composition can empower them to do.
@SimonSapin
Copy link
Contributor Author

This change is smaller than the diff suggests but prettier doesn’t seem to support something like https://sembr.org/ for prose wrapping.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the general shape of these changes, but with the can->should change recommended below.

spec/Section 1 -- Overview.md Outdated Show resolved Hide resolved
spec/Section 1 -- Overview.md Outdated Show resolved Hide resolved
@SimonSapin
Copy link
Contributor Author

Pushed changes that can be squashed

@SimonSapin
Copy link
Contributor Author

@benjie At the moment the PR says “2 workflows awaiting approval”, is there something else I need to do?

@benjie
Copy link
Member

benjie commented Feb 15, 2024

@michaelstaib Thoughts?

@michaelstaib
Copy link
Member

The change is wrong in my mind. The intend is that you can change the general service structure but this must not break the contract with the client.

@michaelstaib michaelstaib merged commit 5591cc1 into graphql:main Apr 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants