-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Overview less prescriptive #23
Conversation
This "must" came across as opinionated on what the reader should do, rather than what composition can empower them to do.
This change is smaller than the diff suggests but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of the general shape of these changes, but with the can->should change recommended below.
Co-authored-by: Benjie <[email protected]>
Pushed changes that can be squashed |
@benjie At the moment the PR says “2 workflows awaiting approval”, is there something else I need to do? |
@michaelstaib Thoughts? |
The change is wrong in my mind. The intend is that you can change the general service structure but this must not break the contract with the client. |
Co-authored-by: Benjie <[email protected]>
This "must" came across as opinionated on what the reader should do, rather than what composition can empower them to do.