External Argument Default Mismatch specification doesn't account for all arguments

[danielreynolds1]

In:

- Let {argumentNames} be the set of all argument names from all fields in
  {fields}.
- For each {argumentName} in {argumentNames}
  - Let {arguments} be the set of all arguments with the name
    {argumentName} from all fields in {fields}.
  - Let {defaultValue} be the first default value found in {arguments}.
  - Let {externalArguments} be the set of all arguments with the name
    {argumentName} from all fields in {externalFields}.
  - For each {externalArgument} in {externalArguments}
    - The default value of {externalArgument} must be equal to
      {defaultValue}.

defaultValue does not specify that it comes from the non-external argument. Therefore iterating over the external arguments prior to doing the check against defaultValue may result in the non-external argument never being accounted for.

[PascalSenn]

Good point, something like this?

- Let {argumentNames} be the set of all argument names from all fields in
  {fields}.
- For each {argumentName} in {argumentNames}
  - Let {arguments} be the set of all arguments with the name
    {argumentName} from all fields in {fields}.
  - Let {defaultValues} be the all default values found in {arguments}.
  - Let {externalArguments} be the set of all arguments with the name
    {argumentName} from all fields in {externalFields}.
  - For each {externalArgument} in {externalArguments}
    - The default value of {externalArgument} must be equal to all
      {defaultValues}.