[Fusion] Added pre-merge validation rule ExternalArgumentDefaultMismatch
#7844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielreynolds1
force-pushed
the
dr/fusion-external-arg-rule
branch
2 times, most recently
from
9981f10 to
83c4394
Compare
danielreynolds1
commented
Dec 17, 2024
...next/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRule.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7844 +/- ##
==========================================
- Coverage 74.33% 74.32% -0.02%
==========================================
Files 2880 2880
Lines 150189 150189
Branches 17468 17468
==========================================
- Hits 111650 111629 -21
- Misses 32726 32747 +21
Partials 5813 5813
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
glen-84
requested changes
Dec 18, 2024
...next/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRule.cs
Outdated
Show resolved
Hide resolved
...next/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRule.cs
Outdated
Show resolved
Hide resolved
...next/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRule.cs
Outdated
Show resolved
Hide resolved
...next/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRule.cs
Outdated
Show resolved
Hide resolved
...next/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRule.cs
Outdated
Show resolved
Hide resolved
...sion.Composition.Tests/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRuleTests.cs
Outdated
Show resolved
Hide resolved
...sion.Composition.Tests/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRuleTests.cs
Outdated
Show resolved
Hide resolved
...sion.Composition.Tests/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRuleTests.cs
Outdated
Show resolved
Hide resolved
...sion.Composition.Tests/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRuleTests.cs
Outdated
Show resolved
Hide resolved
...sion.Composition.Tests/PreMergeValidation/Rules/ExternalArgumentsDefaultMismatchRuleTests.cs
Outdated
Show resolved
Hide resolved
danielreynolds1
force-pushed
the
dr/fusion-external-arg-rule
branch
from
83c4394 to
3e14e88
Compare
danielreynolds1
force-pushed
the
dr/fusion-external-arg-rule
branch
from
3e14e88 to
f18e747
Compare
glen-84
requested changes
Dec 19, 2024
...vnext/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentDefaultMismatchRule.cs
Outdated
Show resolved
Hide resolved
...vnext/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentDefaultMismatchRule.cs
Show resolved
Hide resolved
...vnext/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentDefaultMismatchRule.cs
Show resolved
Hide resolved
src/HotChocolate/Fusion-vnext/src/Fusion.Composition/Properties/CompositionResources.resx
Outdated
Show resolved
Hide resolved
glen-84
reviewed
Dec 19, 2024
...vnext/src/Fusion.Composition/PreMergeValidation/Rules/ExternalArgumentDefaultMismatchRule.cs
Outdated
Show resolved
Hide resolved
danielreynolds1
force-pushed
the
dr/fusion-external-arg-rule
branch
from
4561bb5 to
7701ff1
Compare
glen-84
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)