Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3.11 test coverage issues #512

Merged
merged 2 commits into from
Nov 16, 2024
+3 −4
Merged

Fix python 3.11 test coverage issues #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c264028
Add no cover eof_received in workaround
leszekhanusz Nov 16, 2024
2baf28a
Delete optimized away else
leszekhanusz Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gql/transport/aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def connection_lost(exc, orig_lost):
all_is_lost.set()

def eof_received(orig_eof_received):
try:
try: # pragma: no cover
orig_eof_received()
except AttributeError: # pragma: no cover
# It may happen that eof_received() is called after
Expand Down
5 changes: 2 additions & 3 deletions gql/transport/phoenix_channel_websockets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,9 +342,8 @@ def _validate_data_response(d: Any, label: str) -> dict:

elif status == "timeout":
raise TransportQueryError("reply timeout", query_id=answer_id)
else:
# missing or unrecognized status, just continue
pass

# In case of missing or unrecognized status, just continue

elif event == "phx_error":
# Sent if the channel has crashed
Expand Down
Loading