fix: input object with a nullable field set to null was being removed… #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from the `Args` map given to a resolver.
|
👍 Running into this on our project, too. Seems there's an existing issue as well, #629 |
This was referenced Nov 29, 2022
|
Can this be merged as we are also running into this? |
|
Hi, what chances are that this PR could be merged? |
|
@kindermax As far as I can remember, I don't think that this PR is a complete implementation of nulls - we ended up forking this repo and doing it ourselves but I've since left that company so not sure I have access anymore. |
|
I see( Well for now I've overcome this by passing variables via context but it is a dirty hack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… from the
Argsmap given to a resolver.