Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db] add ability to enable SSL for database connection #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drew-u410
Copy link

  • Adds the ability to enable SSL for the database connection.
  • Maintains existing default behavior of not being enabled.
  • Adds tests for setting options and default options on the database connection.

--

Ran tests locally and they pass as expected:

$ POSTGRES_TEST_DATABASE=test POSTGRES_TEST_PASSWORD=test POSTGRES_TEST_USERNAME=test POSTGRES_TEST_HOST=localhost yarn test

Once this is merged, I intend to open PRs for graphprotocol/indexer to update if accepted.

Thank you.

Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the contribution, @drew-u410!

@drew-u410
Copy link
Author

LGTM 👍 Thanks for the contribution, @drew-u410!

Np- do you intend to merge? If so, on what timeline? I would like to prepare an indexer MR but I can't do so until this is able to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants