Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update release docs and remove release script #175

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

i0n
Copy link
Contributor

@i0n i0n commented Nov 21, 2024

Description

Update release docs and remove release script


Allegedly, clicking on the `Rebase and merge` button in the Github UI has
the same effect.
We try to keep the hostory of the `dev` branch linear, and avoid merge commits. Once your pull request is approved, merge using the `Rebase and merge` button in the Github UI.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We try to keep the hostory of the `dev` branch linear, and avoid merge commits. Once your pull request is approved, merge using the `Rebase and merge` button in the Github UI.
We try to keep the history of the `dev` branch linear, and avoid merge commits. Once your pull request is approved, merge using the `Rebase and merge` button in the Github UI.

Comment on lines +61 to -87
git tag <X.X.X>
git push --tags
```
git tag -a vX.X.X -m "vX.X.X"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we intentionally changing doc to go from annotated tags to "regular"? (dropping the -a). I'd also suggest to start campaigning for signing tags along with commits

```

It's important to note that all changes to the `main` branch should go through pull requests and be reviewed by at least one project admin. This helps ensure that the `main` branch only contains clean releases and that any issues or bugs are caught before they are released to our users.
To start working on a new feature or bug fix, contributors should create a new branch off of the dev branch. Once the feature or bug fix is complete, a pull request should be created to merge the changes into the dev branch. All changes to the dev branch should be reviewed by at least one other person before merging.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think in some places here "should" really is a "need", and the original wording of project admin should be kept. One of the reasons for that is this is a public repo and this doc is meant to also serve external contributors: they can't merge on their own (or with only other external reviewers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants