-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate subgraphs #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-eiger
force-pushed
the
petko/different-subgraphs
branch
4 times, most recently
from
April 18, 2024 10:38
95970f5
to
9214115
Compare
hopeyen
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
pete-eiger
force-pushed
the
petko/different-subgraphs
branch
4 times, most recently
from
April 20, 2024 17:47
269c535
to
23c45b3
Compare
hopeyen
reviewed
Apr 22, 2024
pete-eiger
force-pushed
the
petko/different-subgraphs
branch
from
April 22, 2024 16:24
23c45b3
to
53f2c76
Compare
hopeyen
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a convenient way to differentiate between off-chain syncing and allocated subgraphs. It also addresses an sqlx type issue that probably came from a version update. This change is visible across many panels in the dashboard, most notably in the Comparison Results panel:
It is also visible in Pometheus metrics panels that have a Subgraph deployment hash as a label, they now also have a label, indicating whether or not the Subgraph is allocated to on-chain or not. This label can be used for filtering.
This change also impacts the GraphQL API, because now we return the
allocated
field on the response for the ratio query.