Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate subgraphs #140

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Differentiate subgraphs #140

merged 1 commit into from
Apr 22, 2024

Conversation

pete-eiger
Copy link
Contributor

@pete-eiger pete-eiger commented Apr 17, 2024

This PR aims to add a convenient way to differentiate between off-chain syncing and allocated subgraphs. It also addresses an sqlx type issue that probably came from a version update. This change is visible across many panels in the dashboard, most notably in the Comparison Results panel:
image

It is also visible in Pometheus metrics panels that have a Subgraph deployment hash as a label, they now also have a label, indicating whether or not the Subgraph is allocated to on-chain or not. This label can be used for filtering.

image

This change also impacts the GraphQL API, because now we return the allocatedfield on the response for the ratio query.

@pete-eiger pete-eiger force-pushed the petko/different-subgraphs branch 4 times, most recently from 95970f5 to 9214115 Compare April 18, 2024 10:38
@pete-eiger pete-eiger marked this pull request as ready for review April 18, 2024 10:43
@pete-eiger pete-eiger requested a review from hopeyen April 18, 2024 10:43
@pete-eiger pete-eiger self-assigned this Apr 18, 2024
Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

subgraph-radio/src/database/mod.rs Show resolved Hide resolved
subgraph-radio/src/operator/mod.rs Outdated Show resolved Hide resolved
subgraph-radio/src/operator/mod.rs Show resolved Hide resolved
@pete-eiger pete-eiger force-pushed the petko/different-subgraphs branch 4 times, most recently from 269c535 to 23c45b3 Compare April 20, 2024 17:47
@pete-eiger pete-eiger mentioned this pull request Apr 20, 2024
2 tasks
@pete-eiger pete-eiger requested a review from hopeyen April 20, 2024 17:52
Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@pete-eiger pete-eiger merged commit 50cc851 into dev Apr 22, 2024
11 checks passed
@pete-eiger pete-eiger deleted the petko/different-subgraphs branch April 22, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat.Req] Differentiate between offline and on-chain Subgraphs in Grafana Dashboard
2 participants