Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memory leak #133

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix: memory leak #133

merged 1 commit into from
Mar 4, 2024

Conversation

pete-eiger
Copy link
Contributor

@pete-eiger pete-eiger commented Feb 21, 2024 •
edited
Loading

@pete-eiger pete-eiger force-pushed the petko/fix-memory-leak branch 2 times, most recently from 0b78304 to be8f587 Compare February 27, 2024 09:57
@pete-eiger pete-eiger marked this pull request as ready for review February 27, 2024 09:57
@pete-eiger pete-eiger force-pushed the petko/fix-memory-leak branch 2 times, most recently from d68aacb to 6a740a8 Compare February 28, 2024 13:39
@pete-eiger pete-eiger marked this pull request as draft February 28, 2024 18:47
@pete-eiger pete-eiger marked this pull request as ready for review February 29, 2024 12:14
@pete-eiger
Copy link
Contributor Author

Screen.Recording.2024-02-29.at.12.30.57.mov

@pete-eiger pete-eiger force-pushed the petko/fix-memory-leak branch 4 times, most recently from 2021d73 to c6eaaef Compare February 29, 2024 13:15
hopeyen
hopeyen reviewed Feb 29, 2024
View reviewed changes
subgraph-radio/src/config.rs Outdated Show resolved Hide resolved
subgraph-radio/src/metrics/mod.rs Outdated Show resolved Hide resolved
subgraph-radio/src/operator/attestation.rs Outdated Show resolved Hide resolved
@pete-eiger pete-eiger force-pushed the petko/fix-memory-leak branch 2 times, most recently from 9e08d72 to 8fedc0b Compare March 1, 2024 12:06
@pete-eiger pete-eiger requested a review from hopeyen March 1, 2024 13:38
hopeyen
hopeyen reviewed Mar 4, 2024
View reviewed changes
subgraph-radio/src/metrics/mod.rs Outdated
pub static COMPARISON_RESULTS: Lazy<IntGaugeVec> = Lazy::new(|| {
let m = IntGaugeVec::new(
Opts::new(
"COMPARISON_RESULTS",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still inconsistent cases

@pete-eiger pete-eiger requested a review from hopeyen March 4, 2024 13:59
hopeyen
hopeyen approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pete-eiger pete-eiger merged commit 3b4abff into dev Mar 4, 2024
7 checks passed
@pete-eiger pete-eiger deleted the petko/fix-memory-leak branch March 4, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopeyen hopeyen hopeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pete-eiger @hopeyen