Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update grafana dashboard json #12

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

pete-eiger
Copy link
Contributor

Fixes Grafana dashboard JSON, now it should be transferrable and anyone should be able to import it and use the Subgraph Radio dashboard, as long as their datasources are named "Prometheus" and "GraphQL"

@pete-eiger
Copy link
Contributor Author

will need to update dashboard again when #5 is merged

@pete-eiger pete-eiger force-pushed the petko/update-grafana-json branch 2 times, most recently from 1c210f2 to a06e9d5 Compare July 20, 2023 14:41
@pete-eiger pete-eiger requested a review from hopeyen July 20, 2023 14:44
grafana.json Outdated
"datasource": {
"type": "prometheus",
"uid": "P1809F7CD0C75ACF3"
"uid": "xLT3_kf4k"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please explain this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, looks like I missed it in the cleanup, should be good now

Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the datasource names from GraphQL to SubgraphRadioGraphQL?

grafana.json Outdated
@@ -21,15 +24,12 @@
"editable": true,
"fiscalYearStartMonth": 0,
"graphTooltip": 0,
"id": 27,
"id": 13,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain this change pls?

@pete-eiger pete-eiger merged commit 79e0ed5 into dev Jul 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants