Link Labels Feature #102
Open
Link Labels Feature #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zyansheep Thanks for submitting a pull request. Some of my colleagues have requested this feature recently, so I'm on board. This one will probably involve @Myllaume more than I, so I will ask him to check the code. edit I don't have a specific timeframe to give you because we haven't yet planned the next development cycle, so I'll get back to you on that. (More info on our "Now" page: https://cosma.arthurperret.fr/now.html) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100
This PR is a little messy (changed a few things to make webpack building easier)
Also the code is not very DRY, I basically just copy-pasted the node filter scheme to make it work with links.
Also there is a small bug caused by implementation details with the global link / link label hide / show features (showing all the links will show all links instead of showing all links not filtered).
Lmk what you think!