Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Display link type on links. #100

Open
1 of 4 tasks
zyansheep opened this issue Dec 10, 2023 · 3 comments · May be fixed by #102
Open
1 of 4 tasks

[Enhancement] Display link type on links. #100

zyansheep opened this issue Dec 10, 2023 · 3 comments · May be fixed by #102
Labels
enhancement Feature requests

Comments

@zyansheep
Copy link

Which part of Cosma is your request about?

  • command-line interface
  • cosmoscope (HTML file)
  • documentation
  • other

Describe your request:

I'm not sure if this isn't already possible, but I would like to be able to visualize the names of links between nodes in the graph view.

@zyansheep zyansheep added the enhancement Feature requests label Dec 10, 2023
@infologie
Copy link
Contributor

@zyansheep Thank you for suggesting this. Indeed, Cosma does not display link types in the graph view. I will discuss this with @Myllaume.

@zyansheep
Copy link
Author

I want to try to implement this myself, is there documentation I can look at for the code? Or do I just have to jump in and try to read it myself? If its the second, would it be too much to ask for an overview of which code (files) might have to be changed / added to implement this feature?

@infologie
Copy link
Contributor

infologie commented Dec 14, 2023

@zyansheep There are a couple of hurdles:

  • We have not yet created developer documentation. I'm sorry about this because a few people are starting to want to contribute. The code contains a lot of comments, and follows a classic model-view-controller structure, so some people may find their way through. But I'm no programmer. So if someone needs guidance, @Myllaume is the only one who could answer and he's currently on leave (for a very happy but time-consuming reason).

  • I would like this to be an optional enhancement. Users should be able to choose to generate link labels or not. When they choose to generate them, they should also be able to toggle link label visibility on/off in the graph. This means modifying more than one file, and make UX decisions. @Myllaume will want to review the code for homogeneity, and will want to tweak the UX. So we won't be able to make it a quick fix.

So you're welcome to try! But it might take a while to move from idea to pull request, and then to merging.

edit: forgot to mention that a few colleagues of mine have suggested this enhancement too. So it's on the list of things to explore. I don't know about the feasibility, so if you tackle this, let us know!

@zyansheep zyansheep linked a pull request Dec 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants