Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on CRLF issues in committed migrations #226

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Sep 19, 2024

Description

Fixes #224

The git conversion of LF to CRLF will cause issues not just with header parsing but also with hash signatures; as such we must require that these files are uncompromized. The error message now provides hints how to configure git to not mess with line endings for these files.

Performance impact

Negligible.

Security impact

Negligible.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@benjie benjie merged commit 5148b9d into main Sep 19, 2024
10 checks passed
@benjie benjie deleted the crlf branch September 19, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Invalid migration './migrations/committed/000001.sql' after pulling committed SQL files
1 participant