Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename appuser -> dbowner and link to discussion in issue #215 #216

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

FelixZY
Copy link
Contributor

@FelixZY FelixZY commented Jun 10, 2024

Description

Rename appuser to dbuser to reduce confusion and link to the discussion in #215 when discussing the creation of users and roles.

resolves #215

Performance impact

N/A

Security impact

N/A - Hopefully reduces confusion and makes it easier for users to improve their own security

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

As noted in graphile#215, the naming `appuser` may confuse users into
thinking the account to use for DATABASE_URL is the same as the
account that should be used by the application to connect to the
database. While this may be true in some setups, it is not a hard
requirement (see the discussion in graphile#215 for further details).

resolves graphile#215
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@benjie benjie merged commit 07e5557 into graphile:main Jun 12, 2024
1 of 5 checks passed
@benjie benjie changed the title Rename appuser -> dbuser and link to discussion in issue #215 Rename appuser -> dbowner and link to discussion in issue #215 Jun 12, 2024
@FelixZY FelixZY deleted the fzy/215/1 branch June 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are migrations not always run as the root user/why does graphile-migrate require multiple users?
2 participants