Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: CRUD mutations are not generated for polymorphic types #2089

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

FelixZY
Copy link
Contributor

@FelixZY FelixZY commented Jun 10, 2024

Description

This was mentioned by @benjie in #2077 and #2083 but does not appear to have been explicitly documented yet.

These changes were not discussed beforehand so do let me know if these docs should not be added or are added to the wrong place.

Performance impact

N/A

Security impact

N/A

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

This was mentioned by @benjie in graphile#2077 and graphile#2083 but does not
appear to have been explicitly documented yet.
Copy link

changeset-bot bot commented Jun 10, 2024

⚠️ No Changeset found

Latest commit: b443c26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@benjie benjie merged commit 41e9ab9 into graphile:main Jun 10, 2024
18 checks passed
@FelixZY FelixZY deleted the fzy/2083/1 branch June 10, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants