This repository has been archived by the owner on Feb 21, 2020. It is now read-only.
refactor to allow metric collection to be split between multiple tasks #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For large k8s clusters, it is not possible to collect all metrics in one go. This commit allows metrics to be collected on a per namespace and or per node basis. - Additionally, by allowing per node metrics each node in the cluster can collect its own pod and container metrics.
|
This should allow us to fix grafana/kubernetes-app#46 |
jtlisi
previously approved these changes
Dec 15, 2017
|
@jtlisi what is the "One thing"? |
|
@woodsaj I had approved initially but when I canceled I put one thing as a note. The index value was the one thing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in one go. This commit allows metrics to be collected on a per
namespace and or per node basis.
can collect its own pod and container metrics.