Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for Java profiling using Grafana Alloy in Kubernetes #3603

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

aleks-p
Copy link
Contributor

@aleks-p aleks-p commented Oct 2, 2024

  • Moves the existing example from examples/grafana-agent-auto-instrumentation/java to examples/grafana-agent-auto-instrumentation/java/docker
  • Creates a new example under examples/grafana-agent-auto-instrumentation/java/kubernetes

@aleks-p aleks-p requested a review from a team as a code owner October 2, 2024 19:57
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it makes sense to add this #3599 (alloy helm chart config) into the new Kubernetes README.md?

@aleks-p aleks-p force-pushed the examples/alloy-java-kubernetes branch from 52ad3c2 to 08c1c7c Compare October 3, 2024 11:23
@aleks-p
Copy link
Contributor Author

aleks-p commented Oct 3, 2024

Do you think it makes sense to add this #3599 (alloy helm chart config) into the new Kubernetes README.md?

That is a good point. I've added the capabilities to the yaml file directly and this worked in my local setup. I think the doc section makes sense in our public documentation, but the README.md can be kept more simple (and it links to the docs for more info).

@aleks-p aleks-p merged commit 7905837 into main Oct 3, 2024
18 checks passed
@aleks-p aleks-p deleted the examples/alloy-java-kubernetes branch October 3, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants