-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query-tee: Add an option to shift the query times for comparison #9319
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
232c310
to
3f84ac0
Compare
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
a129912
to
bddd44c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall design LGTM. I left a couple of comments. Would be glad to see a unit test.
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
Added a unit test |
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
I converted this to draft since there is the above bug that I need to fix. |
It is working locally with the docker-compose setup, so I have no clue why it gave issues in the dev environment. I will try running it again in dev next week and try to debug it there. |
What this PR does
Adds an option
proxy.shift-comparison-queries-by
to shift the query times for query-tee comparisons.Sometimes
proxy.compare-skip-recent-samples
option may not be enough because if you want to set it to a higher duration (say few hours), it will completely skip comparing the queries for recent times, which in practice forms a big % of all queries (like recording rules, many most instant queries, etc).With this change, the query-tee still does the query with original times for the preferred backend, but for comparison, it shifts the query times, and does another query to the preferred backend with the shifted times and only one shifted query to the secondary backend and uses those results for comparison.
Added
proxy.shift-comparison-sampling-ratio
to samples the queries for shifting the query times.Draft PR because there are still some TODOs and need to write tests.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.