Fix for #244

[73VW]

Hello @mostafa,

Here's a starting point for a fix for #244.

I am not really sure how I should implement a test for this nor if this is the best way to implement it.

Tell me what do you think about this.

Cheers!

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Mael Pedretti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR was closed because it has been stalled for 10 days with no activity.

[mostafa]

Hey @73VW,

Thanks for your contribution! Please fix the tests and address the comment.

[73VW]

Hello @mostafa,

Thank you for your reply!

This is a breaking change and I don't know if you want to merge it as is because backwards compatibility won't be ensured. Is that fine for you?

[ben-qr]

@mostafa Is it possible to progress this PR? It's causing issues in ours repos that implement the package as we're not passing email as username, so would be great to be able to have this in a new version as soon as possible.
If backwards compatibility is a concern, seems to me that the PR simply needs to pass email as a kwarg when calling create_new_user. My proposal is the only change required to fix the issue is, on line 121:

email = user.get(user_model.EMAIL_FIELD)
kwargs = {"email": email} if email else {}
target_user = create_new_user(user_id, user["first_name"], user["last_name"], **kwargs)

I believe this will be backwards compatible.

Thanks!