Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated usage of Distribution.getBaseName #151

Conversation

PaulFridrick
Copy link
Contributor

This code fixes a Gradle 6 warning, see issue #114

⚠️ This breaks compatibility with Gradle 5

@JLLeitschuh
Copy link
Contributor

Unfortunately, we can't merge this. One of our biggest users continues to rely upon Gradle 5 support. Can you figure out a way to support both Gradle 5 and make this change so we no longer get the deprecation warning?

@big-guy
Copy link
Member

big-guy commented Oct 15, 2020

I've made an attempt at fixing this while maintaining 5.x support. It'll be in the next release (which should be today).

@big-guy big-guy closed this Oct 15, 2020
@PaulFridrick PaulFridrick deleted the distribution_baseName_deprecated branch October 15, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants