Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#142: Remove 2.3 and pre-5 from Docs and Test Coverage #143

Closed
wants to merge 3 commits into from

Conversation

marracuene
Copy link
Contributor

Part of Fix for #142 .
Includes setting maxParallelForks to 1 in order to facilitate investigation of CI build failures.

Remove Play 2.3 support mentions from Docs.

Signed-off-by: marracuene <[email protected]>
Remove 2.3 coverage.
Set maxParallelForks to always 1
gradle#142

Signed-off-by: marracuene <[email protected]>
@marracuene marracuene mentioned this pull request Jul 25, 2020
@JLLeitschuh
Copy link
Contributor

Hey @marracuene I think that the issue you were attempting to solve has been fixed by @cstroe? Is this accurate?

@marracuene
Copy link
Contributor Author

Hey @marracuene I think that the issue you were attempting to solve has been fixed by @cstroe? Is this accurate?

Hi @JLLeitschuh I agree that #147 by @cstroe maxes this PR obsolete. However please note that there he skipped several tests for 2.3, in order to get the build working. Therefore you might want to update the docs to mention that 2.3 support might be patchy?

@marracuene marracuene closed this Oct 5, 2020
@JLLeitschuh
Copy link
Contributor

I think we may have dropped support for 2.3 somewhere. I don't remember. Sorry.

@cstroe
Copy link
Contributor

cstroe commented Oct 7, 2020

The tests that were skipped did not seem to apply to version 2.3. There were many other tests that run with version 2.3, so there is coverage left for that version. I can definitely understand if the decision is made to drop support for 2.3, so don't let me stop you, but that should probably be a new PR.

I tried to document the tests that did not apply to version 2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants