Fix archive baseName #115
Open
Fix archive baseName #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulFridrick
force-pushed
the
fix_archive-baseName
branch
from
ec5a480
to
e971e14
Compare
PaulFridrick
force-pushed
the
fix_archive-baseName
branch
from
e971e14
to
203b75f
Compare
PaulFridrick
force-pushed
the
fix_archive-baseName
branch
from
203b75f
to
19b59a8
Compare
|
Updated to resolve the conflicts with master |
PaulFridrick
force-pushed
the
fix_archive-baseName
branch
from
19b59a8
to
2fb718c
Compare
|
Hey @PaulFridrick this would technically be an API breaking change. If we're going to make this change, it will need to be documented in the release notes. |
|
Hello ! |
PaulFridrick
force-pushed
the
fix_archive-baseName
branch
from
2fb718c
to
38a89fa
Compare
|
Hi, the fix seems to be trivial and is already 3 years old. |
Signed-off-by: Paul Fridrick <[email protected]>
PaulFridrick
force-pushed
the
fix_archive-baseName
branch
from
38a89fa
to
a6aba5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an odd condition in PlayDistributionPlugin:143 when browsing the plugin source code. I think I fixed the generated archives (zip & tar) base name.
I had to change some tests but it seems legitimate in this case.