Skip to content

Commit

Permalink
Complete support for scala 2.8.x, adding tests and plugin support for…
Browse files Browse the repository at this point in the history
… java-forms.

Forked from branch "gabizou:play-2.8" following PR "#154"

Signed-off-by: iacopo.pace <[email protected]>
  • Loading branch information
iaco86 committed Mar 12, 2021
1 parent 432efec commit 02894f7
Show file tree
Hide file tree
Showing 3 changed files with 54 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ private void addAutomaticDependencies(DependencyHandler dependencies, PlayPlatfo
// if the project is Java or Scala based.
case PLAY_2_6_X:
case PLAY_2_7_X:
case PLAY_2_8_X:
dependencies.add(PLATFORM_CONFIGURATION, playPlatform.getDependencyNotation("play-java-forms").get());
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
package org.gradle.playframework.tools.internal.twirl;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;

import org.gradle.playframework.sourcesets.TwirlImports;

class PlayTwirlAdapterV28X implements VersionedPlayTwirlAdapter {

// Based on https://github.com/playframework/playframework/blob/2.8.x/dev-mode/build-link/src/main/java/play/TemplateImports.java
private static List<String> defaultTemplateImports = Collections.unmodifiableList(
Arrays.asList(
"models._",
"controllers._",
"play.api.i18n._",
"play.api.templates.PlayMagic._"
));

private static final List<String> DEFAULT_JAVA_IMPORTS;
private static final List<String> DEFAULT_SCALA_IMPORTS;
static {
List<String> minimalJavaImports = new ArrayList<String>();
minimalJavaImports.addAll(defaultTemplateImports);
minimalJavaImports.add("java.lang._");
minimalJavaImports.add("java.util._");
minimalJavaImports.add("play.core.j.PlayMagicForJava._");
minimalJavaImports.add("play.mvc._");
minimalJavaImports.add("play.api.data.Field");

List<String> defaultJavaImports = new ArrayList<String>();
defaultJavaImports.addAll(minimalJavaImports);
defaultJavaImports.add("play.data._");
defaultJavaImports.add("play.core.j.PlayFormsMagicForJava._");
DEFAULT_JAVA_IMPORTS = Collections.unmodifiableList(defaultJavaImports);

List<String> scalaImports = new ArrayList<String>();
scalaImports.addAll(defaultTemplateImports);
scalaImports.add("play.api.mvc._");
scalaImports.add("play.api.data._");
DEFAULT_SCALA_IMPORTS = Collections.unmodifiableList(scalaImports);
}

@Override
public List<String> getDefaultImports(TwirlImports language) {
return language == TwirlImports.JAVA ? DEFAULT_JAVA_IMPORTS : DEFAULT_SCALA_IMPORTS;
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ public static VersionedPlayTwirlAdapter createPlayTwirlAdapter(PlayPlatform play
return new PlayTwirlAdapterV23X();
case PLAY_2_6_X:
case PLAY_2_7_X:
default:
return new PlayTwirlAdapterV26X();
case PLAY_2_8_X:
default:
return new PlayTwirlAdapterV28X();
}
}

Expand Down

0 comments on commit 02894f7

Please sign in to comment.