This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Add spring-boot sample #743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make master represent 0.11.1 and use now released Gradle 4.2
Release 0.12.1
And don't bother to request auto-applied plugins either.
Merge v0.12.2 on `master` and use Gradle 4.3-RC3
And project.property() in favor of project.objects.property() Take the opportunity and rename to messageProperty
Merge pull request gradle#582 from gradle/bamboo/master/v0.12.3
Replaced by DCO
Merge v0.13.1 into master and upgrade wrappers to Gradle 4.4
Release 0.14.2
Merge pull request gradle#722 from gradle/eskatos/master/gradle-4.5.1
Signed-off-by: Sriram <[email protected]>
|
I think you need to rebase your changes on |
StefMa
reviewed
Mar 6, 2018
| val kotlinVersion = "1.2.21" | ||
| id("org.springframework.boot") version "2.0.0.RELEASE" | ||
| id("org.jetbrains.kotlin.jvm") version kotlinVersion | ||
| id("org.jetbrains.kotlin.plugin.spring") version kotlinVersion |
There was a problem hiding this comment.
Could be replaced with kotlin("plugin.spring") version kotlinVersion
(same for jvm of course)
| } | ||
| } | ||
|
|
||
| val test by tasks.getting(Test::class) { |
There was a problem hiding this comment.
Could be also (tasks.findByName("test") as Test).useJUnitPlatform().
From my point of view it looks better... But don't know 🤷♂️
| dependencies { | ||
| compile("org.springframework.boot:spring-boot-starter-web") | ||
| compile("org.jetbrains.kotlin:kotlin-stdlib-jdk8") | ||
| compile("org.jetbrains.kotlin:kotlin-reflect") |
There was a problem hiding this comment.
You can here use kotlin() as well:
compile(kotlin("stdlib-jdk8"))
compile(kotlin("reflect"))
|
I created this patch from master, so i'll drop this PR and create one from develop branch to avoid conflicts. Also i'll include the review comments in that new PR (#746). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Added spring-boot sample which is missing in the present kotlin-dsl samples.
Contributor Checklist
developbranch./gradlew check --parallel