Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

WIP Introduce composite-build-logic sample #1037

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eskatos
Copy link
Member

@eskatos eskatos commented Aug 13, 2018

Still requires a work around for https://github.com/gradle/gradle-native/issues/522, see the settings.gradle.kts file.

@JLLeitschuh
Copy link
Contributor

@eskatos Can you also include in this sample how to setup the testing environment for the plugin as well?

If someone were to take this sample straight from the repository it would be awesome if the testing mechanisms were already in place.

With two included builds for build logic:
- gradle/shared
- gradle/plugins

And a variety of dependencies including both the outer build and the
plugins included build using the shared included build

Signed-off-by: Paul Merlin <[email protected]>
@eskatos eskatos force-pushed the eskatos/samples/composite-build-logic branch from dbe63c5 to a44b938 Compare October 20, 2018 14:25
Signed-off-by: Paul Merlin <[email protected]>
}
}
}
}
Copy link
Contributor

@JLLeitschuh JLLeitschuh Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?! Does this actually work!? I've been looking to try do do this sort of thing for quite a while now.
Okay. Will try this out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine from Gradle perspective. From my testing it seems IDEA can't import it though. I'll get back to this soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's really good information.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah I do this in my kotlin multiplatform (prior to their recent huge refactor of the MPP plugins) composite projects. I haven't added native yet, so that might be while I don't have any issues with IDEA imports using this technique.

Copy link

@fuzzyweapon fuzzyweapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to start an actual review. Ignore this (auto-approving without actual review).

}
}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah I do this in my kotlin multiplatform (prior to their recent huge refactor of the MPP plugins) composite projects. I haven't added native yet, so that might be while I don't have any issues with IDEA imports using this technique.

@eskatos eskatos added this to the 1.1.0 milestone Nov 6, 2018
@eskatos eskatos modified the milestones: 1.1.0, 2.0.0 Dec 4, 2018
@eskatos eskatos removed this from the 2.0.0 milestone Apr 25, 2019
@eskatos eskatos changed the base branch from develop to master April 25, 2019 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants