Make gradle-profiler work with Android Studio Koala and Ladybug #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asodja
force-pushed
the
asodja/upgrade-profiler
branch
from
37323ce
to
c9339e7
Compare
asodja
force-pushed
the
asodja/upgrade-profiler
branch
from
8b0dcf2
to
eeeed7d
Compare
…n build and buildSrc in one invocation
We probably don't need to test that many versions.
asodja
force-pushed
the
asodja/upgrade-profiler
branch
from
eeeed7d
to
be204df
Compare
asodja
commented
Oct 29, 2024
|
|
||
|
|
||
| @DisableCachingByDefault(because = "Not worth caching") | ||
| abstract class ExtractAndroidStudioTask @Inject constructor( |
There was a problem hiding this comment.
💭 This is the same implementation as we have in gradle/gradle https://github.com/gradle/gradle/blob/81c9b411450ccb9a5c52df2ef77459dad08fddb4/build-logic/integration-testing/src/main/kotlin/gradlebuild/integrationtests/ide/ExtractAndroidStudioTask.kt#L38
asodja
commented
Oct 29, 2024
asodja
changed the title
asodja
changed the title
lptr
reviewed
Oct 29, 2024
src/test/groovy/org/gradle/profiler/AbstractProfilerIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
asodja
force-pushed
the
asodja/upgrade-profiler
branch
from
d37a10b
to
e55ae41
Compare
We don't need to be so specific with -Xmx3100m.
asodja
force-pushed
the
asodja/upgrade-profiler
branch
2 times, most recently
from
9f7dd75
to
df68214
Compare
asodja
force-pushed
the
asodja/upgrade-profiler
branch
2 times, most recently
from
73f625f
to
f1b59f3
Compare
So we can use new ProjectActivity interface.
asodja
force-pushed
the
asodja/upgrade-profiler
branch
from
f1b59f3
to
109ecd4
Compare
lptr
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuous the work from #562