Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #309

wants to merge 1 commit into from
+1 −1

Conversation

quanturium
Copy link

Fixing name of --warmups command parameter

@quanturium
Update README.md
d56eab7 
Fixing name of --warmups command parameter
@lptr
Copy link
Member

lptr commented Feb 5, 2021

Thanks! Could you please sign your commit so it complies with the DCO?

carstenhag
carstenhag suggested changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@carstenhag carstenhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At line 234 there's still a warm-ups usage.

@blundell
Copy link

blundell commented Nov 3, 2021

In my scenario file I have warm-ups (running version 16.0.1)

If I change it to warmups I get

java.lang.IllegalArgumentException: Unrecognized key 'my_scenario.warmups' defined in scenario file tools/gradle-profiler/my.scenarios

Is this readme change a mistake or for something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carstenhag carstenhag carstenhag requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quanturium @lptr @blundell @carstenhag