-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chatbot LaTeX Crash Fix #8658
base: main
Are you sure you want to change the base?
Chatbot LaTeX Crash Fix #8658
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/6437aafcc9e3b87679d62adad1fbb8d7ce0b0d5d/gradio-4.37.2-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@6437aafcc9e3b87679d62adad1fbb8d7ce0b0d5d#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/6437aafcc9e3b87679d62adad1fbb8d7ce0b0d5d/gradio-client-1.2.1.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Can't seem to figure out this bug. This fix helps, but doesn't fully resolve the error: @pngwn if you get a chance, could use a second set of eyes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah interesting! Just one small comment but otherwise looks great. Thanks @dawoodkhan82!
onMount(() => { | ||
el = document.getElementById("container") as HTMLSpanElement; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is essentially the same as the binding, does just having the condition in the afterUpdate
address this issue?
Description
With this fix, it seems to be crashing a lot less. Also doesn't seem like the Latex is being rendered correctly anymore.
Closes: #8006
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh