Bandplan stacking and dynamic bookmark levels #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a band plan I adapted from: Original BandPlan.xml |
pinkavaj
suggested changes
Nov 15, 2022
pinkavaj
reviewed
Nov 16, 2022
pinkavaj
reviewed
Nov 16, 2022
shawnj007
force-pushed
the
plotter_bandplan
branch
from
18bc530
to
293e41e
Compare
shawnj007
commented
Nov 16, 2022
shawnj007
force-pushed
the
plotter_bandplan
branch
2 times, most recently
from
90e7bea
to
a2aeaf1
Compare
|
Sorry for the force pushes, I'm obviously having issues with local branch management. |
FYI: I use force-push for pull requests regularly if not told not to do. So correct behaviour is project dependent :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When plotter is initialized with a small area, the number of bookmark label levels cannot change with resize. Removing the "static const" fixes this issue.
The bandplan now stacks ranges that overlap frequencies. This allows for more complicated bandplans and for all overlapping ranges to be identified.