Fixes for Sony A7R3/4/5 #1067
Open
Fixes for Sony A7R3/4/5 #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
watsonmw
commented
Dec 18, 2024
watsonmw
commented
- Fixes for Sony mode 3 (for A7R4/A7R5):
- capturemode
- flashmode
- iso
- shutterspeed
- f-number
- focusmagnify
- capture-image-and-download
- Allow the following settings to be settable in mode 2 (for A7R3):
- focusmode
- flashmode
- exposure metering
- Re-enabled mode 3 for A7R5, so that:
- iso enum is reported
- focus magnify can be set
- manual focus can be adjusted
- Fixes for Sony mode 3 (A7R4/A7R5): - capturemode - flashmode - iso - shutterspeed - f-number - focusmagnify - capture-image-and-download - Allow the following settings to be settable in mode 2 (A7R3): - focusmode - flashmode - exposure metering - Enabled mode 3 for A7R5, so that: - iso enum is reported - focus magnify can be set - manual focus can be adjusted
msmeissn
reviewed
Dec 18, 2024
| if (dpd->GetSet & 0x80) { | ||
| /* This is a control value and can be set */ | ||
| /* 0x81 - button, 0x83 - lock, 0x82 - notch, 0x84 - variable */ | ||
| dpd->GetSet = PTP_DPGS_GetSet; |
There was a problem hiding this comment.
this is falling through isenabled handling ... should there be an else or goto out or something?
There was a problem hiding this comment.
Ah ok, maybe... I guess some 'controls' can be (legitimately) disabled, like if the exposure mode precludes that action. For now, I'll add an else - since this needs to be tested per control.
… enabled/disabled based on isenabled needs to be tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.