Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: date-fns as regular dependency #2249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benasher44
Copy link

@benasher44 benasher44 commented Jul 2, 2024

Description

See #2240

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Before submitting your pull request, please make sure the following is done:

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have followed the coding guidelines in this project
  • I have tested my changes on different browsers and screen sizes

Linked Issues

#2240

@gpbl gpbl changed the title Make date-fns a regular dependency build: date-fns a regular dependency Jul 2, 2024
@gpbl gpbl changed the title build: date-fns a regular dependency build: date-fns as regular dependency Jul 2, 2024
@gpbl
Copy link
Owner

gpbl commented Jul 3, 2024

Thanks, but what about the locale prop, the jalali calendar and the utc dates?

While we can add date-fns-jalali and @date-fns/utc to the dependencies, I'm not about the right approach for the locale prop.

I'm considering something like:

- import { es } from "date-fns/locale";
+ import { es } from "react-day-picker/locale";

<DayPicker locale={es} />; // Set the locale to Spanish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants