Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle upgrade to 8.2 #52

Closed
wants to merge 1 commit into from
Closed

Conversation

kranthise
Copy link
Collaborator

  • Also some third party library upgrades


test.setRuntimeClasspath(project.files(
test.getOutput(),
main.getOutput(),
project.getConfigurations().getByName(JavaPlugin.TEST_RUNTIME_CONFIGURATION_NAME),
gosuRuntime.inferGosuClasspath(project.getConfigurations().getByName(JavaPlugin.TEST_COMPILE_CONFIGURATION_NAME))));
project.getConfigurations().getByName(JavaPlugin.TEST_RUNTIME_ONLY_CONFIGURATION_NAME),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using testRuntimeClasspath that automatically combines testRuntime and testImplementation,
see https://docs.gradle.org/current/userguide/java_plugin.html#sec:java_plugin_and_dependency_management (scroll down to see the diagrams of configuration dependencies)

Also there might be an error when you try to resolve TEST_RUNTIME_CONFIGURATION_NAME as it is not resolvable by default, while testRuntimeClasspath is resolvable. Example of this behavior https://stackoverflow.com/questions/47910578/not-able-to-copy-configurations-dependencies-after-upgrading-gradle-plugin-for-a

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the configuration. Thank you

@DPUkyle
Copy link
Member

DPUkyle commented Oct 4, 2024

This seems out of date; closing as we are using Gradle 8.6 already.

@DPUkyle DPUkyle closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants